paulirwin commented on PR #1079: URL: https://github.com/apache/lucenenet/pull/1079#issuecomment-2567172861
@NightOwl888 I'm iffy on `ExtractWikipedia.Count`. It's clearly internally mutable, and in Lucene it's possible to mutate it externally, but I don't think it's really supposed to be externally mutable (or even externally readable for that matter). It's pretty low priority to fix this, as this is just in benchmark code so not likely used in the real world, but let me know what you would do here. I could either make it have a private setter, or make it just a private static field instead of public. I also didn't change the increment to use Interlocked since this is not likely to be called so often in a multi-threaded way to where that would be an issue, but I could. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
