NightOwl888 commented on code in PR #1086:
URL: https://github.com/apache/lucenenet/pull/1086#discussion_r1903091930
##########
.build/azure-templates/run-tests-on-os.yml:
##########
@@ -172,6 +172,7 @@ steps:
$tempDirectory = "$(Agent.TempDirectory)"
$isNightly = if ($env:ISNIGHTLY -eq 'true') { 'true' } else { 'false' }
$isWeekly = if ($env:ISWEEKLY -eq 'true') { 'true' } else { 'false' }
+ $displayFullName = if ($env:DISPLAYFULLNAME -eq 'false') { 'false' } else
{ 'true' }
Review Comment:
We should update the documentation to note this extra dependency. Normally,
all dependencies are defined as parameters at the top of the file, which is why
we have this comment:
```
# NOTE: Depends on environment variables $(IsNightly) and $(IsWeekly)
```
Please update it to include `$(DisplayFullName)`.
##########
azure-pipelines.yml:
##########
@@ -119,6 +120,8 @@ stages:
Write-Host "##vso[task.setvariable variable=IsWeekly;]$isWeekly"
$runPack = if ($env:ISRELEASE -eq 'true' -or $env:ARTIFACTFEEDID -ne
'' -or $env:GENERATEPACKAGES -ne 'false') { 'true' } else { 'false' }
Write-Host "##vso[task.setvariable variable=RunPack;]$runPack"
+ $displayFullName = if ($env:DISPLAYFULLNAME -eq 'false') { 'false' }
else { 'true' }
+ Write-Host "##vso[task.setvariable
variable=DisplayFullName;]$displayFullName"
Review Comment:
Since this environment variable is not used in the build stage, we don't
need to set its default here. This can be removed.
This could only make sense if we switch to using a `.runsettings` file
instead of `lucene.testsettings.json` and build that file here for distribution
among the test agents. We do it this way because we would have to write the
settings to a file anyway to transport the settings across agent boundaries
(which makes me miss TeamCity).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
