NightOwl888 commented on code in PR #1084:
URL: https://github.com/apache/lucenenet/pull/1084#discussion_r1903340477
##########
src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs:
##########
@@ -938,6 +937,10 @@ public virtual void TearDown()
if (result.ResultState == ResultState.Failure ||
result.ResultState == ResultState.Error)
{
+ // LUCENENET specific - Track that at least one test in the
suite failed.
+ // LUCENENET TODO: finish implementation of RuleChains so this
is not needed (#1088)
+ SuiteFailureMarker = false;
Review Comment:
According to ChatGPT, that isn't how that works. It resets the state at the
beginning of every test:
https://chatgpt.com/share/677af21b-bcb8-8005-ad95-b070d0c6cdaa.
But whatever the case, I am hesitant to merge this to master when a test
failure could leave all of the temporary files on disk for every successful
test in the assembly that runs after it. There is a specific setting for that:
`tests:leavetmpdir`.
> Side note: In NUnit, a failure isn't always an exception and
`Assert.Pass()` throws a `SuccssException`. So, the `TestRuleMarkFailure` logic
won't work as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
