paulirwin commented on code in PR #1084:
URL: https://github.com/apache/lucenenet/pull/1084#discussion_r1903347722
##########
src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs:
##########
@@ -938,6 +937,10 @@ public virtual void TearDown()
if (result.ResultState == ResultState.Failure ||
result.ResultState == ResultState.Error)
{
+ // LUCENENET specific - Track that at least one test in the
suite failed.
+ // LUCENENET TODO: finish implementation of RuleChains so this
is not needed (#1088)
+ SuiteFailureMarker = false;
Review Comment:
I really debated whether we should even be doing this anyways in the issue
comments. Again, no Lucene tests even use this attribute. I'll let you take
ownership of this one from here because I'm losing interest in the purity
aspect of getting this working when there is no actual benefit to our code. You
can feel free to use whatever of this PR might be useful in your other test
framework changes and I'm just going to mark this as draft for now. I'd
appreciate getting some of my other PRs reviewed ahead of this one, anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
