paulirwin commented on code in PR #1: URL: https://github.com/apache/lucenenet-codeanalysis-dev/pull/1#discussion_r1992691024
########## .github/workflows/Lucene.Net.CodeAnalysis.Dev.yml: ########## @@ -0,0 +1,28 @@ +# This workflow will build a .NET project +# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net + +name: Lucene.Net.CodeAnalysis.Dev + +on: + push: + branches: [ "main" ] + pull_request: + branches: [ "main" ] Review Comment: We can sort out release/versioning/etc. concerns in a later PR. For now, I've made those changes for the pull request and dispatch triggers. On most other projects, I like doing a main push build as well, since sometimes there might be subtle differences when merged/squashed that can cause build or test failures... but I'm also fine with leaving that off for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
