NightOwl888 commented on PR #1170: URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239283073
> @NightOwl888 > > Thanks — that makes sense. > > Your approach sounds clean and avoids too much duplication. I’m happy to try setting that up now, unless you’d prefer to handle it yourself since you already have the structure in mind. > > Either way, I’ll follow your lead — just let me know what you prefer. I have been working on this, but came to a bit of a fork in the road when it comes to setting it up because of how the different configurations are setup between legacy apps and new. I have a setup that simply does what I said, but it would be much cleaner if there were only 1 `NewHttpServer()` overload without so many branching paths, so I am attempting to unify the configuration a bit more between older and newer versions of ASP.NET Core. Anyway, let me work on it a bit more before handing it off to you. I think I can come up with a compromise without digging too deep into the custom configuration territory (where `Lucene.Net.Extensions` is meant to shine). > Also, one quick thing — after my last push yesterday, I noticed in the checks that 2 tests failed (I also got the email around 5/6 ie github try to re run but it fail). But now everything shows green and all tests are passing. Do you know if there was any specific reason for that? Did you make some changes, or does GitHub sometimes re-run and fix it automatically? I wasn’t fully sure why that happened. Yeah, I spotted the failures and saw that they were due to server connectivity problems, not actual software failures. So, I restarted the tests and they succeeded the second time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
