NehanPathan commented on PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3239469777
> Minor feedback added about some comments in the code. @NehanPathan I'm
open to approving this without the J2N-ported unit tests if you want to do that
in a follow-up PR, or let me know if you are already working on porting those
and will have that done soon. Thanks!
@paulirwin
I have already added the J2N-ported async tests in the last commit, as per
Shad’s suggestion.
pls correct me if i misunderstood....
And
Regarding the commented-out code: that is our old synchronous code. We left
it commented for future reference while adding the new async code. Shad is
currently working on that part only ie separating the testing code so that both
synchronous and asynchronous code can be tested independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
