On Thu, Aug 21, 2014 at 7:26 PM, Marvin Humphrey <[email protected]> wrote:
> [ ] +1 Release RC 1 as Apache Clownfish 0.4.0.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Clownfish 0.4.0 because...
+1
Sums and sigs verified.
Builds and passes tests for both compiler and runtime on:
OS X Mavericks 10.9.4
stock Perl 5.16.2
stock clang Apple LLVM version 5.1 (clang-503.0.40)
Windows Server 2008
ActivePerl 5.14
Strawberry Perl 5.14
Cygwin Perl 5.10.1
MinGW (bundled with Strawberry Perl)
Cygwin gcc
MSVC 2010 Express
CentOS 6
Custom compiled debugging Perl 5.16 (?)
Additionally, the `test_valgrind` build target passes for both compiler and
runtime on CentOS 6.
Double checked:
* CHANGES
* LICENSE
* NOTICE (IMO we should change the wording slightly but no big deal)
* CONTRIBUTING
* README
* INSTALL
* compiler/c/INSTALL
* compiler/perl/INSTALL
* runtime/c/INSTALL
* runtime/perl/INSTALL
I also rechecked the CPAN dists generated by ./Build dist and found
two glitches. Neither block my +1 release vote.
* Clownfish::CFC::Model::Version has version 0 rather than 0.4.0. This is
because it doesn't have it's own .pm file with a $VERSION in it. I'm
going to add one before generating the CPAN dist.
* CFC is not getting added appropriately as a prereq for the Clownfish
runtime, an artifact of trying to silence the warnings about CFC not being
installed. This would cause cascading failure for both the runtime and
Lucy if it isn't addressed. I'll add the key manually before shipping the
CPAN dist.
Marvin Humphrey
