Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/184#discussion_r139041379
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -55,15 +71,23 @@ copy knn_test_data (id, "DATA") from stdin delimiter
'|';
6|{50,45}
\.
drop table if exists madlib_knn_result_classification;
-select
knn('"KNN_TRAIN_DATA"','"DATA"','label','knn_test_data','"DATA"','id','madlib_knn_result_classification','c',3);
+select
knn('knn_train_data','data','id','label','knn_test_data','data','id','madlib_knn_result_classification',3,False);
select assert(array_agg(prediction order by id)='{1,1,0,1,0,0}', 'Wrong
output in classification with k=3') from madlib_knn_result_classification;
+drop table if exists madlib_knn_result_classification;
+select
knn('knn_train_data','data','id','label','knn_test_data','data','id','madlib_knn_result_classification',3,True);
+select assert(array_agg(k_nearest_neighbours order by id)='{
{1,2,3},{5,4,3},{7,6,5},{4,5,3},{9,6,7},{6,7,8} }', 'Wrong output in
classification with k=3') from madlib_knn_result_classification;
--- End diff --
IC fails on greenplum 4.3 with the following error:
```
select assert(array_agg(k_nearest_neighbours order by id)='{
{1,2,3},{5,4,3},{7,6,5},{4,5,3},{9,6,7},{6,7,8} }', 'Wrong output in
classification with k=3') from madlib_knn_result_classification;
psql:/tmp/madlib-logs-GREENPLUM_4_3ORCA/madlib.834EYG/knn/test/knn.sql_in.tmp:159:
ERROR: could not find array type for data type integer[]
LINE 1: select assert(array_agg(k_nearest_neighbours order by id)='{...
```
---
