Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/184#discussion_r139027504
--- Diff: src/ports/postgres/modules/knn/knn.py_in ---
@@ -36,19 +36,20 @@ from utilities.utilities import unique_string
from utilities.control import MinWarning
-def knn_validate_src(schema_madlib, point_source, point_column_name,
+def knn_validate_src(schema_madlib, point_source,
point_column_name,point_id,
label_column_name, test_source, test_column_name,
- id_column_name, output_table, operation, k, **kwargs):
-
- if not operation or operation not in ['c', 'r']:
- plpy.error("kNN Error: operation='{0}' is an invalid value, has to
be"
- " 'r' for regression OR 'c' for classification.".
- format(operation))
+ test_id, output_table, k, output_neighbors ,
**kwargs):
+ # if not operation or operation not in ['c', 'r']:
--- End diff --
We should remove these commented lines from the final code.
---
