Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/244#discussion_r177915929
  
    --- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
    @@ -66,7 +66,12 @@ SELECT pagerank(
                  'id',            -- Vertix id column
                  '"EDGE"',          -- "EDGE" table
                  'src=src, dest=dest', -- "EDGE" args
    -             'pagerank_out'); -- Output table of PageRank
    +             'pagerank_out',    -- Output table of PageRank
    +              NULL,             -- Default damping factor (0.85)
    +              NULL,             -- Default max iters (100)
    +              NULL,             -- Default Threshold 
    +              NULL,             -- No Grouping 
    +             NULL);             -- Personlized Nodes
    --- End diff --
    
    In this case, we can remove the last 5 NULLs since they are all optional.


---

Reply via email to