Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/244#discussion_r177916814
  
    --- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
    @@ -95,6 +101,49 @@ SELECT assert(relative_error(SUM(pagerank), 1) < 
0.00001,
         ) FROM pagerank_gr_out WHERE user_id=2;
     
     
    +-- Tests for Personalized Page Rank
    +
    +-- Test without grouping 
    +
    +DROP TABLE IF EXISTS pagerank_ppr_out;
    +DROP TABLE IF EXISTS pagerank_ppr_out_summary;
    +SELECT pagerank(
    +             'vertex',        -- Vertex table
    +             'id',            -- Vertix id column
    +             '"EDGE"',          -- "EDGE" table
    +             'src=src, dest=dest', -- "EDGE" args
    +             'pagerank_ppr_out', -- Output table of PageRank
    +             NULL,              -- Default damping factor (0.85)
    +             NULL,              -- Default max iters (100)
    +             NULL,              -- Default Threshold 
    +             NULL,         -- Grouping column
    +            '{1,3}');             -- Personlized Nodes
    +
    +
    +-- View the PageRank of all vertices, sorted by their scores.
    +SELECT assert(relative_error(SUM(pagerank), 1) < 0.00124,
    --- End diff --
    
    Is this  0.00124 based on current test result? Can we make it smaller?


---

Reply via email to