Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/269#discussion_r186711399
  
    --- Diff: src/ports/postgres/modules/stats/correlation.py_in ---
    @@ -34,9 +40,18 @@ def correlation(schema_madlib, source_table, 
output_table,
             Tuple (output table name, number of columns, time for computation)
         """
         with MinWarning("info" if verbose else "error"):
    -        _validate_corr_arg(source_table, output_table)
    +        if get_cov:
    --- End diff --
    
    One-liner might be cleaner: `function_name = 'Covariance' if get_cov else 
'Correlation'`


---

Reply via email to