Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/269#discussion_r186714879
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -800,26 +800,39 @@ def get_table_qualified_col_str(tbl_name, col_list):
for col in col_list])
+def validate_reserved_and_target_cols_intersection(source_table,
--- End diff --
A few suggestions here:
- If this is a validation function then it's better in `validate_args.py_in`
- This can be generalized for any reserved names and not just columns. This
would require moving out the `cols_in_tbl_valid`, which in IMO is cleaner since
the function does double duty right now.
- Could we please have a shorter name for this - something that does not
include the "how" (i.e. intersection)? Maybe `does_exclude_reserved`? The
argument names could also be just `targets` and `reserved` to not restrict them
to column names.
---
