Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191586806 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir # ------------------------------------------------------------------------------ +def _cleanup_comments_in_sqlfile(output_filename, upgrade): --- End diff -- This function does more than just cleaning up the comments. It also creates a new file with the cleaned contents. Maybe rename the function to reflect this ?
---