Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/271#discussion_r191585342
--- Diff: src/madpack/madpack.py ---
@@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port):
return maddir
#
------------------------------------------------------------------------------
+def _cleanup_comments_in_sqlfile(output_filename, upgrade):
--- End diff --
should this function be moved to the `ScriptCleaner` class ? There is some
code duplication in `_clean_comment` function and this function.
---
