Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/306#discussion_r207707589
  
    --- Diff: deploy/CMakeLists.txt ---
    @@ -10,13 +10,29 @@ if(APPLE)
             PackageMaker
         )
     elseif(UNIX)
    -    list(APPEND CPACK_GENERATOR
    -        RPM
    -    )
    +    debian_version(DEB_VERSION)
    +    if(NOT (DEB_VERSION STREQUAL "DEB_VERSION-NOTFOUND"))
    +      set(IS_DEBIAN "True")
    +    endif()
    +    rh_version(REDHAT)
    +    if(NOT (RH_VERSION STREQUAL "RH_VERSION-NOTFOUND"))
    +      set(IS_REDHAT "True")
    +    endif()
    +    if(IS_REDHAT)
    +        message(STATUS "Detected RH version ${RH_VERSION}")
    +        list(APPEND CPACK_GENERATOR
    +            RPM
    +        )
    +    elseif(IS_DEBIAN)
    +        message(STATUS "Detected Debian version ${DEB_VERSION}")
    +        list(APPEND CPACK_GENERATOR
    +            DEB
    +        )
    +    endif()
     endif()
     
     
    -# -- General settings for all/multiple packages generators 
---------------------
    +# -- General settings for ll/multiple packages generators 
---------------------
    --- End diff --
    
    Accidental delete?


---

Reply via email to