Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/306#discussion_r207707579
  
    --- Diff: cmake/LinuxUtils.cmake ---
    @@ -10,3 +10,37 @@ macro(rh_version OUT_VERSION)
         endif(EXISTS "/etc/redhat-release")
     endmacro(rh_version)
     
    +# Get the Debian version
    +# DEB_OUT_VERSION will have a number if /etc/issue exists, with an entry 
for Debian.
    +# DEB_OUT_VERSION will have 'DEB_OUT_VERSION-NOTFOUND' if /etc/issue does 
not exist.
    +# DEB_OUT_VERSION will be empty if some distribution which has /etc/issue, 
but not Debian in it. 
    +macro(debian_version DEB_OUT_VERSION)
    +    if(EXISTS "/etc/issue")
    +        file(READ "/etc/issue" _DEB_RELEASE_CONTENT)
    +        string(REGEX REPLACE "Debian[^0-9.]*([0-9.]+)[^0-9.]*\$" "\\1"
    +        ${DEB_OUT_VERSION}
    +            "${_DEB_RELEASE_CONTENT}"
    +        )
    +    else(EXISTS "/etc/issue")
    +        set(${DEB_OUT_VERSION} "${DEB_OUT_VERSION}-NOTFOUND")
    +    endif(EXISTS "/etc/issue")
    +endmacro(debian_version)
    +        
    +#macro(debian_version DEB_OUT_VERSION)
    --- End diff --
    
    We can delete the backup function. 


---

Reply via email to