Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/315#discussion_r214484071
--- Diff: src/ports/postgres/modules/knn/knn.py_in ---
@@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source,
point_column_name, point_id,
if label_column_name and label_column_name.strip():
cols_in_tbl_valid(point_source, [label_column_name], 'kNN')
- cols_in_tbl_valid(point_source, (point_column_name, point_id), 'kNN')
- cols_in_tbl_valid(test_source, (test_column_name, test_id), 'kNN')
--- End diff --
`point_id` and `test_id` params are not validated anymore. This should
still be done, since the new asserts only check for `point_column_name` and
`test_column_name` being valid expressions. This validation is required to
catch invalid values such as `NULL`, `''`, invalid or non-existing column name
etc. for `point_id` and `test_id` params.
---
