Github user fmcquillan99 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/315#discussion_r215462116
--- Diff: src/ports/postgres/modules/knn/knn.py_in ---
@@ -53,22 +55,12 @@ def knn_validate_src(schema_madlib, point_source,
point_column_name, point_id,
if label_column_name and label_column_name.strip():
cols_in_tbl_valid(point_source, [label_column_name], 'kNN')
- cols_in_tbl_valid(point_source, (point_column_name, point_id), 'kNN')
- cols_in_tbl_valid(test_source, (test_column_name, test_id), 'kNN')
-
- if not is_col_array(point_source, point_column_name):
- plpy.error("kNN Error: Feature column '{0}' in train table is not"
- " an array.".format(point_column_name))
- if not is_col_array(test_source, test_column_name):
- plpy.error("kNN Error: Feature column '{0}' in test table is not"
- " an array.".format(test_column_name))
--- End diff --
Yes I agree that this error message is too vague. So in retrospect I
suggest we do check that a valid array type is generated by the expression.
Sorry if I mislead earlier @hpandeycodeit
@njayaram2 do you have an existing function that we can use for this check?
---
