kaknikhil commented on a change in pull request #368: DL: Add alternative
options for compile params
URL: https://github.com/apache/madlib/pull/368#discussion_r275460877
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -168,7 +168,8 @@ def fit(schema_madlib, source_table, model,
dependent_varname,
KerasWeightsSerializer.deserialize_weights(model_state,
model_shapes)
master_model.set_weights(updated_weights)
(opt_name,final_args,compile_dict) =
parse_compile_params(compile_params)
- master_model.compile(optimizer=optimizers[opt_name](**final_args),
Review comment:
We should add a JIRA number to the commit message and maybe make the commit
message a bit more verbose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
