kaknikhil commented on a change in pull request #368: DL: Add alternative
options for compile params
URL: https://github.com/apache/madlib/pull/368#discussion_r275474254
##########
File path: src/ports/postgres/modules/deep_learning/test/madlib_keras.sql_in
##########
@@ -202,3 +202,18 @@ select assert(trap_error($TRAP$madlib_keras_predict(
'x',
'cifar10_predict');$TRAP$) = 1,
'Passing batched image table to predict should error out.');
+
+DROP TABLE IF EXISTS keras_out, keras_out_summary;
+SELECT madlib_keras_fit(
+ 'cifar_10_sample_batched',
+ 'keras_out',
+ 'dependent_var',
+ 'independent_var',
+ 'model_arch',
+ 1,
+ $$ optimizer='SGD', loss=losses.categorical_crossentropy,
metrics=['accuracy']$$::text,
Review comment:
Consider adding an assert to check if `optimizer, loss and metrics` were
stored as expected in the summary table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
