kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added
stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#discussion_r320411546
##########
File path: src/ports/postgres/modules/lda/lda.py_in
##########
@@ -255,15 +294,42 @@ class LDATrainer:
self.init_random()
# sstime = time.time()
for it in range(1, self.iter_num + 1):
+ # JIRA: MADLIB-1351
+ # If the Perplexity_diff is less than the perplexity_tol,
+ # Stop the iteration
+ if self.perplexity_diff < self.perplexity_tol:
Review comment:
We should also add a test case for this condition. Either unit test or dev
check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
