kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added
stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#discussion_r324802991
##########
File path: src/ports/postgres/modules/lda/test/lda.sql_in
##########
@@ -288,3 +288,126 @@ CREATE OR REPLACE FUNCTION validate_lda_output() RETURNS
integer AS $$
$$ LANGUAGE plpgsql;
select validate_lda_output();
+
+
+---------- TEST CASES FOR PERPLEXITY ----------
+
+drop table if exists lda_model, lda_output_data;
+SELECT lda_train(
+ 'lda_training',
+ 'lda_model',
+ 'lda_output_data',
+ 20, 5, 2, 10, 0.01, 2, .2);
+
+SELECT assert(perplexity_iters = '{2}', 'Number of Perplexity iterations are
wrong') from lda_model;
Review comment:
1. We can also assert the len of the perplexity values.
1. Since we cannot deterministically assert the perplexity value itself, we
should at least assert that all the perplexity values > 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
