reductionista commented on a change in pull request #440: DL: Update training_preprocessor_dl to use bytea URL: https://github.com/apache/madlib/pull/440#discussion_r322485649
########## File path: src/ports/postgres/modules/deep_learning/test/input_data_preprocessor.sql_in ########## @@ -197,10 +191,10 @@ SELECT training_preprocessor_dl( 'x', 4, 5); -SELECT assert(pg_typeof(dependent_var) = 'smallint[]'::regtype, 'One-hot encode doesn''t convert into integer array format') FROM data_preprocessor_input_batch WHERE buffer_id = 0; -SELECT assert(array_upper(dependent_var, 2) = 2, 'Incorrect one-hot encode dimension') FROM - data_preprocessor_input_batch WHERE buffer_id = 0; -SELECT assert(SUM(y) = 1, 'Incorrect one-hot encode format') FROM (SELECT buffer_id, UNNEST(dependent_var[1:1]) as y FROM data_preprocessor_input_batch) a WHERE buffer_id = 0; +SELECT assert(pg_typeof(dependent_var) = 'bytea'::regtype, 'One-hot encode doesn''t convert into integer array format') FROM data_preprocessor_input_batch WHERE buffer_id = 0; +SELECT assert(dependent_var_shape = '[1:3][1:2]', 'Incorrect one-hot encode dimension') FROM + data_preprocessor_input_batch WHERE buffer_id = 0; Review comment: See above ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
