reductionista commented on a change in pull request #440: DL: Update
training_preprocessor_dl to use bytea
URL: https://github.com/apache/madlib/pull/440#discussion_r322414534
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -1753,8 +1757,10 @@ DROP AGGREGATE IF EXISTS MADLIB_SCHEMA.fit_step(
INTEGER,
BYTEA);
CREATE AGGREGATE MADLIB_SCHEMA.fit_step(
- /* dep_var */ SMALLINT[],
- /* ind_var */ REAL[],
+ /* dep_var */ BYTEA,
+ /* ind_var */ BYTEA,
+ /* dep_var_shape */ TEXT,
+ /* ind_var_shape */ TEXT,
Review comment:
(If suggestion in `input_data_preprocessor` taken, then these would be
`INTEGER[] instead of TEXT`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
