kaknikhil commented on a change in pull request #441: Kmeans: simplified 
silhouette per point for k-means
URL: https://github.com/apache/madlib/pull/441#discussion_r325323045
 
 

 ##########
 File path: src/ports/postgres/modules/kmeans/test/kmeans.sql_in
 ##########
 @@ -81,11 +81,37 @@ COPY km_sample (pid, points) FROM stdin DELIMITER '|';
 10 | {13.86, 1.35, 2.27, 16, 98, 2.98, 3.15, 0.22, 1.8500, 7.2199, 1.01, NULL, 
1045}
 \.
 
+DROP TABLE IF EXISTS centroids_null, silh_out;
 
+CREATE TABLE centroids_null AS
 
 Review comment:
   why is this table called centroids_null? The `centroids_null` table itself 
doesn't contain any null value, is it only because it was created from the 
`km_sample` table that had a null value in it ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to