kaknikhil commented on a change in pull request #441: Kmeans: simplified
silhouette per point for k-means
URL: https://github.com/apache/madlib/pull/441#discussion_r324932073
##########
File path: src/ports/postgres/modules/kmeans/kmeans.py_in
##########
@@ -224,7 +227,17 @@ def compute_kmeans_random_seeding(schema_madlib,
rel_args, rel_state,
m = it.evaluate("_args.k - coalesce(array_upper({0}, 1),
0)".format(state_str))
return iterationCtrl.iteration
#
------------------------------------------------------------------------------
+def _create_temp_view_for_expr(schema_madlib, rel_source, expr_point):
+ if kmeans_validate_expr(schema_madlib, rel_source, expr_point):
Review comment:
Consider adding a docstring for this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
