Advitya17 commented on a change in pull request #518:
URL: https://github.com/apache/madlib/pull/518#discussion_r495088887
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_automl.py_in
##########
@@ -835,10 +835,10 @@ class AutoMLHyperopt(KerasAutoML):
if param_value_list[-1] == 'linear':
return hp.uniform(cp, param_value_list[0], param_value_list[1])
elif param_value_list[-1] == 'log':
- return hp.loguniform(cp, param_value_list[0],
param_value_list[1])
+ return hp.loguniform(cp, np.log(param_value_list[0]),
np.log(param_value_list[1]))
else:
plpy.error("DL: Please choose a valid distribution type for
'{0}': {1}".format(
- cp, ['linear', 'log']))
+ cp[:-2], ['linear', 'log']))
Review comment:
Good point, though a rare occurrence. I've made a general purpose
function to deal with all of these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
