Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/48#discussion_r68995358
--- Diff: src/ports/postgres/modules/svm/svm.py_in ---
@@ -676,27 +985,32 @@ def svm_help(schema_madlib, message, is_svc,
**kwargs):
def svm(schema_madlib, source_table, model_table,
dependent_varname, independent_varname, kernel_func,
kernel_params, grouping_col, params, is_svc,
- verbose, detect_novelty=False, **kwargs):
+ verbose, add_intercept=False, **kwargs):
"""
Executes the linear support vector classification algorithm.
"""
# verbosing
- verbosity_level = "info" if verbose else "error"
+ verbosity_level = "warning" if verbose else "error"
with MinWarning(verbosity_level):
_verify_table(source_table, model_table,
dependent_varname, independent_varname)
grouping_str, grouping_col = \
_get_grouping_col_str(schema_madlib, source_table,
grouping_col)
kernel_func = _get_kernel_name(kernel_func)
- transformer = _random_feature_map(schema_madlib, source_table,
+ transformer = _transform_w_kernel(schema_madlib, source_table,
dependent_varname,
independent_varname,
- kernel_func, kernel_params,
grouping_col)
+ kernel_func, kernel_params,
+ grouping_col, add_intercept
+ )
params_dict = _extract_params(schema_madlib, params)
args = locals()
- if transformer is not None:
+ if transformer and transformer.transformed_table:
--- End diff --
There are a few places where we check against `none` for `transformer` and
there are places such as in `_build_output_tables` where we assume
`transformer` is always a valid object. I think it is safe to assume it is
always a valid object since we enforce it in `_get_kernel_name` and
`_transform_w_kernel`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
