Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/48#discussion_r68996075
--- Diff: src/ports/postgres/modules/svm/svm.py_in ---
@@ -144,30 +145,37 @@ def _verify_get_params_dict(params_dict):
def _build_output_tables(n_iters_run, model_table, args, transformer,
**kwargs):
- if transformer is None:
+ # transformer should always be a valid object
+ original_table = transformer.original_table
+ if not original_table:
--- End diff --
I agree we should add a note to ensure that future kernels never set it to
empty. It also makes sense that `original_table` should always be non-empty
otherwise there is nothing to train from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
