Github user mktal commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/70#discussion_r83715452
  
    --- Diff: src/madpack/madpack.py ---
    @@ -357,7 +356,7 @@ def _get_rev_num(rev):
             @param rev version text
         """
         try:
    -        num = re.findall('[0-9]', rev)
    --- End diff --
    
    Could rev be something like `Greenplum Database 4.3.10.0`, containing text 
before the version number? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to