Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/70#discussion_r83716471
--- Diff: src/madpack/madpack.py ---
@@ -357,7 +356,7 @@ def _get_rev_num(rev):
@param rev version text
"""
try:
- num = re.findall('[0-9]', rev)
--- End diff --
All the usages of `_get_rev_num` indicates that we only send a pre-parsed
version number containing just the digits. I guess we can indicate that further
in the doc string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---