Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/69#discussion_r86890072
--- Diff: src/ports/postgres/modules/convex/utils_regularization.py_in ---
@@ -89,6 +88,8 @@ def __utils_normalize_data(y_decenter=True, **kwargs):
col_ind_var_norm_new -- create a new name for the scaled array
to be compatible with array[...] expressions
"""
+
+ group_col = _cast_if_null(kwargs.get('grouping_col'),
unique_string('grp_col'))
--- End diff --
`kwargs.get('grouping_col')` returning `None` if the grouping_col does not
exist is on purpose here? If yes, please add the `None` explicitly even though
it's default so that someone does not change this in the future to
`kwargs['grouping_col']`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
