Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/69#discussion_r86892534
--- Diff: src/ports/postgres/modules/elastic_net/elastic_net.py_in ---
@@ -554,7 +750,8 @@ def elastic_net_predict_all(schema_madlib, tbl_model,
tbl_new_source,
{dense_vars_str} as ind_var
FROM
{tbl_new_source}) tbl2
--- End diff --
The queries in the two branches above look the same except for a
`{grouping_col}` in a select list and a `USING ({grouping_col})` join
condition. Can we parameterize both those strings and add it to a single query
string?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
