Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/80#discussion_r92717819
  
    --- Diff: src/ports/postgres/modules/knn/knn.py_in ---
    @@ -0,0 +1,36 @@
    +# coding=utf-8
    +m4_changequote(`<!', `!>')
    +
    +"""
    +@file knn.py_in
    +
    +@brief knn: Driver functions
    +
    +@namespace knn
    +
    +@brief knn: Driver functions
    +"""
    +
    +import plpy
    +
    +#from utilities.control import IterationController2D
    +#from utilities.control_composite import IterationControllerComposite
    +from utilities.validate_args import table_exists
    +from utilities.validate_args import table_is_empty
    +
    +STATE_IN_MEM = m4_ifdef(<!__HAWQ__!>, <!True!>, <!False!>)
    +HAS_FUNCTION_PROPERTIES = m4_ifdef(<!__HAS_FUNCTION_PROPERTIES__!>, 
<!True!>, <!False!>)
    +UDF_ON_SEGMENT_NOT_ALLOWED = m4_ifdef(<!__UDF_ON_SEGMENT_NOT_ALLOWED__!>, 
<!True!>, <!False!>)
    +# ----------------------------------------------------------------------
    +
    +
    +def knn_validate_src(schema_madlib, rel_source, **kwargs):
    +    if rel_source is None or rel_source.strip().lower() in ('null', ''):
    --- End diff --
    
    I guess you can replace this with `if not rel_source:`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to