Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/80#discussion_r92721150
--- Diff: src/ports/postgres/modules/knn/test/knn.sql_in ---
@@ -0,0 +1,6 @@
+m4_include(`SQLCommon.m4')
+/*
-----------------------------------------------------------------------------
+ * Test knn.
+ *
+ * FIXME: Verify results
+ *
-------------------------------------------------------------------------- */
--- End diff --
Please go ahead and add few test cases, that would
check if knn is actually running as expected. Use small toy
data sets to do the same. We can run install checks to
perform some basic sanity checks of the module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
