Github user njayaram2 commented on the issue:
https://github.com/apache/incubator-madlib/pull/81
Hi Auon,
If you plan to make more changes and update your PR, I suggest you update
your master and rebase it on your knn branch. Assuming "master" refers to
apache/incubator-madlib in your setup, do the following AFTER you make
changes to the knn feature branch and committing them, but BEFORE pushing
it:
Assuming you are in features/knn branch, and have committed your changes.
- git checkout master
- git pull --ff-only
- git checkout features/knn
- git rebase master
Now you can push the code
(A useful git command to visualize where your HEAD and various branches
are, is: git log --graph --decorate --oneline --all)
- git push <your-repo-name>
I think your local master is a few commits behind the
apache/incubator-madlib master. It is good to do the above before you push
any code to your feature branch.
NJ
On Fri, Jan 20, 2017 at 9:28 AM, Orhan Kislal <[email protected]>
wrote:
> Hi Auon,
> My suggestion is to give them a try and if you agree with the content,
> merge them.
> Here is a small list of validations (I know you covered some of them in
> the code):
>
> - Every input should be checked for null
> - Every string should be checked for empty string ''
> - Columns should exist in their respective tables
> - Input Tables should not be empty
> - Output tables should not exist
> Thanks
> Orhan
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-madlib/pull/81#issuecomment-274129861>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AQoSTGep9pq3tORaZu4zMTtZ9jT4uNNqks5rUO6-gaJpZM4LRcDa>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
