Github user njayaram2 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/81
  
    Some more input error checks, apart from what Orhan has already mentioned 
above (note that
    you may have already covered some of these, I just listed things out of the 
top of my head):
    - validity of types of parameters `point_column_name` (must be an array), 
`label_column_name`
    (must be an int/bool), `test_column_name` (must be an array) and 
`id_column_name` (integer).
    - validity of the `operation` parameter. Look for error cases such as 
empty, NULL, `xyz` etc.
    - validity of the `k` parameter. Look for error cases such as 0, -1, and a 
number greater than
    the total number of rows in `point_source`.
    
    It's probably easier to validate input parameters in python since you can 
use existing helper
    functions in MADlib python modules such as `utilities.validate_args` and 
`utilities.utilities`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to