Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/163
  
    The change looks good. 
    
    Few comments: 
    - An alternative to changing the threshold is to reduce the max number of 
iterations. Even with the lower threshold, we're not necessarily guaranteed 
quicker completion. 
    - The log file can be accessed even with the test passing by adding `-vl` 
option to the `madpack install-check` command. The options indicate `-v: 
Verbose` and `-l: Keep logs`. 
    - The install-check itself also provides the run time for execution of the 
whole file. However, `\timing` is needed if run time for individual queries is 
desired. 
    
    @njayaram2 Any idea why the asserts on `log_likelihood` are commented out? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to