On 9/13/10 5:29 AM, Robin Anil wrote:
On top of that I question whether we need MultiLabelVector and
WeightedVector at all, cant multilabel and instance weight be nullable
fields inside Vector. I dont see a big win (space efficiency) in keeping a
verbose name and separate subclasses just to add 2 fields. A boolean bit can
be kept to see if weight or labels are serialized.
Didn't we start out with names as vector instance variables and refactor
them into NamedVector? I agree with Sean's points about subclassing
VectorWritable and would be +1 to convert WeightedVectorWritable into a
WeightedVector wrapper instead. The same for MultiLabelVector.
