Lance,

The JobConf cleanup sounds like a good place to start. I'll be on vacation 
through Dec 31 and will start on this at the beginning of January. Thanks,

Walter



________________________________
From: Lance Norskog <[email protected]>
To: [email protected]
Sent: Thu, December 23, 2010 8:35:24 PM
Subject: Re: Mahout code coverage

Walter- in the middle up there is another very useful code sweep:
changing to the new Hadoop signatures.

For example: Hadoop JobConf is old and deprecated, Configuration is
new. JobConf is a subclass of Configuration to assist transition. The
task would be to find everywhere JobConf is used and figure out how to
switch to Configuration. I complained about this a few days ago and
Sean graciously did a sweep. Usually just unit tests have to change,
and of course user code.

Another great project is to fix code that uses 'instanceof' to use
object-oriented programming instead.


Lance

On 12/23/10, Ted Dunning <[email protected]> wrote:
> Please, everybody else should help with this, of course.  "TODO delete" will
> be the key string.
>
> On Thu, Dec 23, 2010 at 12:45 PM, Ted Dunning <[email protected]> wrote:
>
>> OK.  I don't know about 1.0 just yet, but I will start marking Colt
>> classes
>> for demolition and will post the current list roughly weekly.
>>
>> I will then start deleting classes that seem to have lazy consent.
>>
>>
>> On Thu, Dec 23, 2010 at 12:42 PM, Jeff Eastman <[email protected]> wrote:
>>
>>> +1 from me too
>>>
>>> -----Original Message-----
>>> From: Sean Owen [mailto:[email protected]]
>>> Sent: Thursday, December 23, 2010 12:33 PM
>>> To: [email protected]
>>> Subject: Re: Mahout code coverage
>>>
>>> +1 from me for sure.
>>>
>>> This and getting off Hadoop's deprecated APIs are good steps forward to a
>>> 1.0 release.
>>>
>>> On Thu, Dec 23, 2010 at 8:30 PM, Ted Dunning <[email protected]>
>>> wrote:
>>>
>>> > Can we agree on some sort of way to annotate classes that might be
>>> deleted?
>>> >
>>> > I would suggest:
>>> >
>>> > // TODO remove before 0.5
>>> >
>>> > I am happy to add a bunch of these and summarize all of the annotations
>>> > that
>>> > I or anybody else makes.  Sound good?
>>> >
>>> > I agree that now is a great time to drop a lot of unused code and I
>>> would
>>> > be
>>> > happy to cut deep rather than be cautious.
>>>
>>
>>
>


-- 
Lance Norskog
[email protected]



      

Reply via email to