[
https://issues.apache.org/jira/browse/MAHOUT-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010619#comment-13010619
]
Sean Owen commented on MAHOUT-586:
----------------------------------
OK, each patch ought to be committable -- at least does something useful and
compiles. So you could re-add this extra code.
Is this intended for a commit? or just food for thought. If it's the latter,
I'm going to close the issue to help with planning for 0.5, but it can still be
used as a place to iterate.
I don't doubt this does something useful. Your last patch which was committed
added the order-based bit. You're saying you want to give the user the chance
to supply the test vs training data, but I think that's not quite what the
patch does. It also does that, but adds other functions, changes an API, and
deletes functionality.
It's the latter two I am taking issue with really.
Any other comments from the lurkers?
> Redo RecommenderEvaluator for modularity
> ----------------------------------------
>
> Key: MAHOUT-586
> URL: https://issues.apache.org/jira/browse/MAHOUT-586
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Lance Norskog
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: MAHOUT-559.patch, MAHOUT-586.patch, MAHOUT-586.patch,
> MAHOUT-586.patch
>
>
> The RecommenderEvaluator implementation is hard-coded around one algorithm.
> This is a more flexible, modular rewrite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
