[
https://issues.apache.org/jira/browse/MAHOUT-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010730#comment-13010730
]
Ted Dunning commented on MAHOUT-586:
------------------------------------
Lance,
I think that your comment was taken out of context, but it exhibits stylistic
traits I consider really bad.
The two points are:
- almost no code should ever call System.exit(). Throw an appropriate
exception instead. Code that exits is very difficult to test.
- similarly, please never catch Exception. Catch the correct exception and
deal with it appropriately. If you want to exit, just let the exceptions code.
Related to this, don't do as many people do and print a stacktrace and exit.
Just let the exception cause the program to do that for you.
> Redo RecommenderEvaluator for modularity
> ----------------------------------------
>
> Key: MAHOUT-586
> URL: https://issues.apache.org/jira/browse/MAHOUT-586
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Lance Norskog
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: MAHOUT-559.patch, MAHOUT-586.patch, MAHOUT-586.patch,
> MAHOUT-586.patch
>
>
> The RecommenderEvaluator implementation is hard-coded around one algorithm.
> This is a more flexible, modular rewrite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
