[
https://issues.apache.org/jira/browse/MAHOUT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Owen updated MAHOUT-633:
-----------------------------
Attachment: MAHOUT-633.patch
Here comes a new version of the patch. Yes I have in here glob and list
support, ReflectionUtils, and avoiding creation of extra key instances where
not needed.
This actually should be called the "Great Iterator Patch". I kept finding
little things around Iterators, Iterables, PathFilters as well that could be
refactored and threw it into the mix. I really like the result, but, it's a
doozy of a patch. It does delete a net 500 lines of code, tests pass, it's
definitely standardized about 80% of the interaction with reading sequence
files, and fixed a few small bugs along the way (see what I did to
StableFixedSizeSamplingIterator for instance -- it wasn't stable).
Sebastian I think there are appropriate calls to makeQualified().
Dmitriy let me now go read your comments, I had not actually seen them yet!
> Add SequenceFileIterable; put Iterable stuff in one place
> ---------------------------------------------------------
>
> Key: MAHOUT-633
> URL: https://issues.apache.org/jira/browse/MAHOUT-633
> Project: Mahout
> Issue Type: Improvement
> Components: Classification, Clustering, Collaborative Filtering
> Affects Versions: 0.4
> Reporter: Sean Owen
> Assignee: Sean Owen
> Priority: Minor
> Labels: iterable, iterator, sequence-file
> Fix For: 0.5
>
> Attachments: MAHOUT-633.patch, MAHOUT-633.patch, MAHOUT-633.patch
>
>
> In another project I have a useful little class, SequenceFileIterable, which
> simplifies iterating over a sequence file. It's like FileLineIterable. I'd
> like to add it, then use it throughout the code. See patch, which for now
> merely has the proposed new classes.
> Well it also moves some other iterator-related classes that seemed to be
> outside their rightful home in common.iterator.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
