[ 
https://issues.apache.org/jira/browse/MAHOUT-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037229#comment-13037229
 ] 

Sean Owen commented on MAHOUT-687:
----------------------------------

OK, that is still not what the patch does though.
I think there are two good ideas in the mix here that can be committed without 
controversy. First, work around setSeed() behavior by instantiating a new RNG 
when called. Second, don't use a shared RNG in the sampling Iterator. I suggest 
this is the substance of what to commit in this thread.

> Random generator objects- slight refactor
> -----------------------------------------
>
>                 Key: MAHOUT-687
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-687
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Lance Norskog
>            Priority: Minor
>         Attachments: MAHOUT-687.patch, MAHOUT-687.patch
>
>
> Problems:
> * The uncommons RepeatableRNG classes are the basis of RandomUtils.
> ** These classes cheerfully ignore setSeed.
> * Some people in the project want to move off Uncommons anyway.
> This patch uses the org.apache.commons.math.random.RandomGenerator classes 
> instead of org.apache.uncommons.maths.RepeatableRNG classes.
> .

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to