[ 
https://issues.apache.org/jira/browse/MAHOUT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042736#comment-13042736
 ] 

Sean Owen commented on MAHOUT-718:
----------------------------------

I like it, though there are many more places where stuff is close()-ed, and we 
have about 3-4 methods for this already. I'd be fine just using Closeables, but 
let's do it across the board.

Also can TopItmes use the TopK class? it's another place where the top K things 
are taken and I don't see that this patch touches it.



> Small refactoring to broaden the use of Google Guava
> ----------------------------------------------------
>
>                 Key: MAHOUT-718
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-718
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Sebastian Schelter
>            Assignee: Sebastian Schelter
>             Fix For: 0.6
>
>         Attachments: MAHOUT-718.patch
>
>
> a little refactoring that introduces util classes to fetch the top k and min 
> k elements of a collection and broadens the use of Google Guava

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to