[ 
https://issues.apache.org/jira/browse/MAHOUT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043347#comment-13043347
 ] 

Sebastian Schelter commented on MAHOUT-718:
-------------------------------------------

You're right, we should try to replace all the closing logic with one solution 
(Closeables from Guava). 

I didn't touch TopItems because TopK always instantiates a new object before 
doing the comparison and I thought that could maybe hurt the crucial 
performance of TopItems. Actually I'm not sure what the cost of instantiating a 
few hundred or thousands objects is, maybe it's neglectible?

> Small refactoring to broaden the use of Google Guava
> ----------------------------------------------------
>
>                 Key: MAHOUT-718
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-718
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.6
>            Reporter: Sebastian Schelter
>            Assignee: Sebastian Schelter
>             Fix For: 0.6
>
>         Attachments: MAHOUT-718.patch
>
>
> a little refactoring that introduces util classes to fetch the top k and min 
> k elements of a collection and broadens the use of Google Guava

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to