[
https://issues.apache.org/jira/browse/MAHOUT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049314#comment-13049314
]
Sean Owen commented on MAHOUT-731:
----------------------------------
I think Apache code style guidelines discourage @author tags on individual
files. This policy encourages everyone to view all the code as "theirs".
The patch is fine, as it is, and is attached here in JIRA "for the record". I
don't think it needs to be committed. I assure you I also will make sure this
gets in, in the right form.
And yes if you have time to adjust this patch as we've discussed, that would be
great. I think you're welcome to keep it simple: extend the PostgreSQL
implementation and override. Don't bother with MySQL. Even though it kind of
makes some sense that the "SQL92" implementation is the base version, in
practice a SQL92-compliant database that isn't one of the two supported RDBMSes
is the rare beast.
That said, if you really wanted to do a big proper clean refactoring to put the
SQL92 implementation as the parent, I wouldn't object if it were nice and tidy.
I wouldn't tell you that you need to do this though.
> Add SQL92JDBCDataModel
> ----------------------
>
> Key: MAHOUT-731
> URL: https://issues.apache.org/jira/browse/MAHOUT-731
> Project: Mahout
> Issue Type: New Feature
> Components: Collaborative Filtering
> Affects Versions: 0.6
> Reporter: Daniel Xiaodan Zhou
> Assignee: Sean Owen
> Labels: drupal_integration
> Fix For: 0.6
>
> Attachments: SQL92.patch
>
>
> I'm thinking to work on a patch that adds SQL92JDBCDataModel based on the
> sample code of PostgreSQLJDBCDataModel. This class will only use standard
> SQL92. It won't be high performance, but would have maximum compatibility to
> other popular DBMS, such as Oracle, SQLlite, etc. This is quite important to
> Drupal/Mahout integration.
> Before I actually write the code, is there any suggestions or concerns?
> Thanks!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
