[
https://issues.apache.org/jira/browse/MAHOUT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049385#comment-13049385
]
Daniel Xiaodan Zhou commented on MAHOUT-731:
--------------------------------------------
I will remove @author tags from SQL92 implementation to follow Mahout standard.
For the record, I think the Apache coding guideline
(http://portals.apache.org/development/code-standards.html) suggests using the
@author tags.
I agree not to bother with MySQL. Between Postgres and SQL92, I'd rather have
SQL92 as base. Because SQL92 is not likely to change in the future, but
Postgres might. Especially if you look at PostgreSQLJDBCDataModel.java line 62:
private static final String POSTGRESQL_DUPLICATE_KEY_STATE = "23505"; // this
is brittle...
This is probably going to change in the future, and might affect SQL92 if SQL92
derives from Postgres...
On the other hand, the benefit of duplicated code is that it allows some
independence. Besides, the only duplication between SQL92 and Postgres is with
the constructors (and the fact that they both override setPreference(), though
differently). It has some but not much benefit to have Postgres extends SQL92
or vice versa. So I think the current implementation is fine too.
The reason I'd like to push SQL92 is that Drupal 7 supports Oracle/MSSQL/SQLite
(http://drupal.org/requirements). So I need to make sure Mahout can access
those databases too for Drupal/Mahout integration.
What do you think?
> Add SQL92JDBCDataModel
> ----------------------
>
> Key: MAHOUT-731
> URL: https://issues.apache.org/jira/browse/MAHOUT-731
> Project: Mahout
> Issue Type: New Feature
> Components: Collaborative Filtering
> Affects Versions: 0.6
> Reporter: Daniel Xiaodan Zhou
> Assignee: Sean Owen
> Labels: drupal_integration
> Fix For: 0.6
>
> Attachments: SQL92.patch
>
>
> I'm thinking to work on a patch that adds SQL92JDBCDataModel based on the
> sample code of PostgreSQLJDBCDataModel. This class will only use standard
> SQL92. It won't be high performance, but would have maximum compatibility to
> other popular DBMS, such as Oracle, SQLlite, etc. This is quite important to
> Drupal/Mahout integration.
> Before I actually write the code, is there any suggestions or concerns?
> Thanks!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
